chore(extract): rename synapt_extract → synapt.extract (PEP 420) + extract_batch skeleton - #29
Conversation
…420) + extract_batch skeleton Unify the extract Python package under the synapt.* namespace (PEP 420), matching synapt.recall + synapt.premium. extract was the odd one out in underscore-top-level form (Layne 2026-07-13). - Package dir: src/synapt_extract/ -> src/synapt/extract/ (namespace package; NO src/synapt/__init__.py, so it coexists with synapt.recall/synapt.premium). - Import path: synapt_extract -> synapt.extract / synapt.extract.batch. PyPI DIST name UNCHANGED (synapt-extract). pyproject: packages.find namespaces=true + package-data key synapt.extract. - prompt.py repo-root resolution parents[4] -> parents[5] (module moved one level deeper). The response-format string literal "synapt_extraction_stage1" is left intact (renamed only package references, keyed on the trailing dot). - Existing 21 test files + examples/dogfood.py imports updated. 307 existing tests pass against the renamed package (verified, fresh venv). - extract_batch SKELETON folded in at synapt/extract/batch.py: API conformed to the pinned contract + Sentinel's spec (async, BatchFailureReason Literal, BatchUnit, injected infer seam, BatchUnitResult, _coerce_shape/_strip_output_hygiene). Bodies raise NotImplementedError -- impl lands in the follow-up PR. Sentinel's rebased extract#28 will COLLECT and run RED (not ImportError). NO PUBLISH (Layne-gated; breaking version bump deferred). npm/TS (@synapt-dev/extract) HELD -- Python only for now. Cross-repo follow-on (Opus's recall-wiring lane, post-publish): recall imports the old path -- synapt/pyproject.toml `synapt-extract>=0.5.0` (dist dep, unaffected) and consolidate.py:46 `from synapt_extract import ...` (module import -> synapt.extract). Contained now by NO-PUBLISH: recall runs against published v0.5.0 (old path); the consolidate.py:46 update happens when the renamed version is published + recall rewires. Premium boundary: OSS (IL primitive, no identity/org).
|
Sentinel review. Reviewer-2: REQUEST CHANGES. HIGH: the code moved, but build/release substrate still targets the old package path. This is reproduced in the current CI run: Please update:
Keep Also sweep the Python import examples in the root/package READMEs and the package-copy commands in The PEP 420 layout, internal imports, prompt parent-depth fix, public batch skeleton, and 307-test result otherwise read clean. |
…name (Sentinel review) Reviewer-2 (Sentinel) caught refs the .py-only sweep missed — CI build-python copied prompts to the removed src/synapt_extract/prompts (0 prompt JSON) and schema-drift diffed the removed src/synapt_extract/schemas. PATH refs src/synapt_extract/ -> src/synapt/extract/: - .github/workflows/ci.yml (prompt copy 40-41,208-209; schema-drift diff 157) - .github/workflows/publish-pypi.yml (prompt copy 28-29) - .gitignore (generated prompts path) - SECURITY.md (prompt + schema copy commands) IMPORT refs from synapt_extract import -> from synapt.extract import + `synapt_extract` prose -> `synapt.extract`: - README.md + packages/python/README.md Python examples KEPT unchanged (correct): response-format name strings "synapt_extract_stage1" / "synapt_extraction_stage1"; synapt_extract.egg-info (dist stays synapt-extract, untracked/generated anyway); @synapt-dev/extract npm (held). Verified by fruit: simulated the CI copy with fixed paths -> 4 prompt JSON (incl. capabilities.json) bundle under the package; _INSTALLED_PROMPTS resolves; registry loads. Whole-repo grep now clean except the intended KEEPs.
|
Addressed all REQUEST-CHANGES findings — pushed Path refs
Import refs in root + package READMEs: Kept unchanged (per your note): response-format name strings Verified by fruit — simulated the CI Ready for re-review. Thanks for catching the repo-wide sweep — the .py-only grep missed CI/docs/config, and the CI-copy break was the concrete fruit. |
|
Sentinel review. Reviewer-2: CLEAN PASS on 23902ca. The prior HIGH is resolved by fruit:
The PEP 420 namespace move, package metadata, internal imports, resource fallback depth, docs/release substrate, preserved response-format names, and extract_batch skeleton now read clean. No remaining blocker. Approved to merge to sprint-39. |
1 participant
What
Rename the extract Python package
synapt_extract→synapt.extract(PEP 420 namespace, matchingsynapt.recall+synapt.premium), and fold in theextract_batchskeleton atsynapt/extract/batch.py. Layne directive 2026-07-13 — extract was the odd one out in underscore-top-level form; unify it.Changes
src/synapt_extract/→src/synapt/extract/(namespace package; nosrc/synapt/__init__.py, so it coexists with recall/premium). History preserved (git renames).synapt_extract→synapt.extract/synapt.extract.batch. PyPI dist name UNCHANGED (synapt-extract). pyproject:packages.find namespaces=true+package-datakey"synapt.extract".prompt.pyrepo-root resolutionparents[4]→parents[5](module moved one level deeper). The response-format string literal"synapt_extraction_stage1"is left intact (rewrite keyed on the trailing dot, not a blind substring replace).examples/dogfood.pyimports updated.extract_batchskeleton atsynapt/extract/batch.py: API conformed to the pinned contract + Sentinel's spec (asyncextract_batch,BatchFailureReasonLiteral,BatchUnit, injectedinferseam,BatchUnitResult,_coerce_shape/_strip_output_hygiene). Bodies raiseNotImplementedError— impl lands in the follow-up PR. Sentinel's rebased extract#28 will COLLECT and run RED, not ImportError.Verification (fresh venv, editable install)
import synapt.extractOK;synaptis a true PEP 420 namespace package (__file__is None); capability registry loads.get_args(BatchFailureReason)=={unparseable, schema_invalid, dropped, merged};extract_batchis a coroutine function.NO PUBLISH
Layne-gated (breaking version bump deferred). npm/TS (
@synapt-dev/extract) HELD — Python only for now.Cross-repo follow-on (Opus's recall-wiring lane, post-publish)
recall imports the old path:
synapt/pyproject.tomlsynapt-extract>=0.5.0(dist dep — unaffected, dist name unchanged) andconsolidate.py:46from synapt_extract import ...(module import → needssynapt.extract). Contained now by NO-PUBLISH: recall runs against publishedv0.5.0(old path); theconsolidate.py:46update happens when the renamed version is published and recall rewires. Flagging so it's tracked, not discovered later — Layne's "only scaffold + spec use the old name" was incomplete.Premium boundary
OSS — IL primitive, no identity/org.
Reviewers
Opus + Sentinel. Base
sprint-39. @sentinel: this is the SHA to rebase extract#28's two imports onto.